Review kit parity map #

Classification: Restricted (describes source code structure).

Feature-by-feature and field-by-field map of what the review shows today onto the kit mechanism that carries it, with the status of each row and an Approved column for the owners (Estu, Koki, Ryota). The review core’s fixtures cite rows as “parity n”. Companion to the Review Kit ADR and the inventory.

Sources: the i18n labels of 22 review namespaces (config/i18n/en/webapp.json), the BS editor API (ui-v2/bank-statement/core/types.ts, intl/labels.ts), the onboarding cards, and the 6 YAML files in config/extraction_fields/. Written 2026-10-21.

Type TW = the tofu-web product review page (/entities/{slug}/review), added 2026-10-22: the kit is used there too, not only in onboarding.

Status: covered = in the kit or SheetGrid today, or plain props · sheetgrid-ext = a SheetGrid extension (#6003) · new-presenter = a small new presenter in ui-v2 · container = outside the kit, the container’s job · backend = needs bonsapi data · dropped = deliberately not carried over.

Features (94) #

Summary: covered 62, container 2, new-presenter 7, dropped 1, sheetgrid-ext 9, backend 1

SheetGrid extensions derived from this map #

• #45 Column kinds (number, money, percentage, date, async picker per row, multiselect, status, read-only derived) → SheetGrid has only text / boolean / select today
• #46 Picker in a cell: Create New, option groups, “(Archived)”, mandatory, Unknown account / tax rate + reason → options[].group/archived/mandatory, renderOption, cellErrors; refusal in the container’s applyChange
• #47 Bounding box per cell: hover reveal, lens, pulse → rows[].cells[].box + onCellHover; ZoomLensOverlay
• #48 Error per cell + Previous/Next problem navigation → cellErrors + LinesCard error navigation
• #50 Tax amount editable toggle + tooltip → columns[].editableToggle + tooltip (small)
• #51 Discount as “10%” or an amount → columns[].parse (percentage|money), a parser per column
• #58 Child transactions (parent/child, split) → rows[].parentId + indentation
• #61 Drag to reorder → onReorder(sectionId, from, to) + drag handle in the gutter
• #69 Ext. Balance vs Calc. Balance, ✓ status per row → read-only derived column + status column

Small new presenters #

• #7 Lock with a reason and a way back from ready → model.lock { reason } → ReviewNotice + readOnly; revert dialog = confirmation
• #8 Validation summary “N things to fix” → model.errors[] → ReviewValidationBar + cellErrors/fieldErrors
• #9 “New extraction data available → Update form” → ReviewNotice with an action
• #11 Sync info (last publish/import, status, error, View in provider, retry) → SyncInfo presenter (ported from ui-v2 bank-statement-host)
• #12 Activities history → ActivitiesPanel presenter, data from the container
• #13 Duplicates → ReviewNotice with actions; resolution in the container
• #22 Contra defaults per account + Apply → SectionDefaults presenter + onSectionAction(apply_defaults)

Field catalog (179) → kit control #

Non-feature inputs (95+), 114 rows #

Every input from scans [1]–[7] of the inventory that is not a feature: entity settings, accounting config fields, metadata flags, capabilities, number decisions, validation points, the 18 statuses, document/permission/onboarding (R2.9, 2026-10-23). ctx field = kunci ReviewContext; Fixture id = the named context in libs/typescript/utils/src/review/fixtures/contexts/ that exercises it. Status backend = a gap only bonsapi can close; the kit tolerates it. The full list of read sites is attached to ENG-9191.

Input summary: backend 7, container 23, covered 83, sheetgrid-ext 1

Acceptance criteria (skeleton, ENG-9191) #

Rows from the features table whose Types include the type; dropped rows are left out. Filled in review by Estu, Koki and Ryota: a row counts once its Approved cell says yes. Onboarding-only rows (OB) are listed apart: the kit gives them to every type, so the reviewers decide whether each one is a criterion too.

Acceptance criteria M3.5.5 (direct expense, ENG-9196) #

• Document: #1, #2, #3, #4, #5, #6, #8, #9, #10, #11, #12, #13, #14
• Verdict: #24, #26, #27, #28, #30
• Header fields: #33, #34, #35, #36, #42
• Lines: #44, #45, #46, #50, #52, #53, #54, #56, #57, #62, #63, #66, #67, #70, #71
• Footer: #73, #74, #78, #79
• Document panel: #80
• Input (95+): #97, #101, #102, #103, #106, #107, #108, #109, #110, #111, #112, #113, #114, #115, #122, #123, #124, #126, #127, #128, #129, #130, #131, #132, #133, #139, #140, #141, #142, #143, #145, #147, #148, #149, #153, #154, #155, #156, #157, #159, #160, #161, #163, #164, #165, #166, #167, #168, #170, #171, #172, #174, #177, #178, #180, #181, #182, #183, #184, #185, #186, #187, #188, #189, #190, #191, #192, #193, #194, #195, #196, #197, #198, #199, #200, #201, #202, #203, #204, #205, #206, #207, #208
• Total: 43 rows
• Onboarding-only (OB), to decide: #7, #15, #31, #47, #48, #49, #68, #76, #77, #81, #82

Acceptance criteria M3.5.6 (bank statement, ENG-9197) #

• Document: #1, #2, #3, #4, #5, #6, #8, #9, #10, #11, #12, #13, #14
• Account (BS): #16, #17, #18, #19, #20, #21, #22
• Verdict: #26, #29, #32
• Header fields: #33, #34, #35, #36, #43
• Lines: #44, #45, #46, #52, #53, #54, #55, #56, #57, #58, #59, #60, #61, #63, #64, #65, #67, #69, #70, #71, #72
• Footer: #74, #75, #78
• Document panel: #80
• Input (95+): #98, #103, #106, #107, #111, #115, #116, #117, #118, #119, #120, #121, #122, #146, #147, #151, #152, #154, #158, #163, #164, #165, #166, #168, #171, #173, #175, #178, #179, #180, #181, #182, #183, #184, #185, #186, #187, #188, #189, #190, #191, #192, #193, #194, #195, #196, #197, #198, #199, #200, #201, #202, #203, #204, #205, #206, #207, #208
• Total: 53 rows; dropped and left out: #23
• Onboarding-only (OB), to decide: #7, #15, #31, #47, #48, #49, #68, #76, #77, #81, #82

Acceptance criteria M3.5.7 (credit notes, ENG-9198) #

• Document: #1, #2, #3, #4, #5, #6, #8, #9, #10, #11, #12, #13, #14
• Verdict: #24, #26, #27, #28, #30
• Header fields: #33, #34, #35, #36, #38, #39, #40, #41
• Lines: #44, #45, #46, #51, #52, #53, #54, #56, #57, #62, #67, #71
• Footer: #73, #74, #78
• Document panel: #80
• Input (95+): #99, #100, #102, #103, #104, #106, #107, #108, #109, #111, #112, #113, #114, #122, #123, #124, #126, #127, #128, #129, #130, #131, #132, #133, #135, #139, #140, #141, #142, #143, #145, #147, #148, #150, #154, #155, #156, #157, #159, #160, #161, #162, #163, #164, #165, #166, #167, #168, #170, #171, #174, #176, #178, #180, #181, #182, #183, #184, #185, #186, #187, #188, #189, #190, #191, #192, #193, #194, #195, #196, #197, #198, #199, #200, #201, #202, #203, #204, #205, #206, #207, #208
• Total: 42 rows
• Onboarding-only (OB), to decide: #7, #15, #31, #47, #48, #49, #68, #76, #77, #81, #82